Skip to content

Add warning to rename script #34

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 20, 2024
Merged

Add warning to rename script #34

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
4d4935f
Add warning
rocketnova Jun 19, 2024
a701691
Add debug lines
rocketnova Jun 19, 2024
11d009c
Remove accidentally hard coding
rocketnova Jun 19, 2024
f6841bd
Add newline
rocketnova Jun 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion template-only-bin/download-and-install-template
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ git checkout "$target_version"
cd - &> /dev/null

echo "Installing ${template_name}..."
curl "https://raw.githubusercontent.com/navapbc/${template_name}/rocket/update-template-only-bin-scripts/template-only-bin/install-template" | bash -s -- "${template_name}" "${app_name}"
curl "https://raw.githubusercontent.com/navapbc/${template_name}/main/template-only-bin/install-template" | bash -s -- "${template_name}" "${app_name}"

echo "Storing template version in a file..."
cd "${template_name}"
Expand Down
2 changes: 1 addition & 1 deletion template-only-bin/install-template
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ cd "${template_name}"

if [ "${template_short_name}" != "${app_name}" ]; then
echo "Modifying template to use ${app_name} instead of ${template_short_name}..."
curl "https://raw.githubusercontent.com/navapbc/${template_name}/rocket/update-template-only-bin-scripts/template-only-bin/rename-template-app" | bash -s -- "${template_short_name}" "${app_name}"
curl "https://raw.githubusercontent.com/navapbc/${template_name}/main/template-only-bin/rename-template-app" | bash -s -- "${template_short_name}" "${app_name}"
fi

# Note: Keep this list in sync with the files listed in update-template
Expand Down
4 changes: 4 additions & 0 deletions template-only-bin/rename-template-app
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,3 +83,7 @@ for include_path in "${include_paths[@]}"; do
mv "${include_path}" "${new_include_path}"
fi
done

echo
echo "===> Review all changes carefully using 'git diff' before committing!"
echo
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: add newline at EOF

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the catch.

Loading