A suite of dependency upgrades #376
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Coverage report for
|
St.❔ |
Category | Percentage | Covered / Total |
|---|---|---|---|
| 🟢 | Statements | 97.92% | 47/48 |
| 🟢 | Branches | 85.71% | 6/7 |
| 🟢 | Functions | 100% | 8/8 |
| 🟢 | Lines | 100% | 40/40 |
Test suite run success
5 tests passing in 3 suites.
Report generated by 🧪jest coverage report action from ee8538e
aligg
commented
Dec 17, 2024
coilysiren
reviewed
Dec 18, 2024
app/.eslintrc.js
Outdated
| @@ -64,7 +64,7 @@ module.exports = { | |||
| "@typescript-eslint/no-unused-vars": "error", | |||
| // The usage of `any` defeats the purpose of typescript. Consider using `unknown` type instead instead. | |||
| "@typescript-eslint/no-explicit-any": "error", | |||
| }, | |||
| \ }, | |||
There was a problem hiding this comment.
@coilysiren thank you! ran out of time yesterday, sorry for the churn on this one. Knock on wood, should be ready for re-review now 🙇♀️
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
Resolves #{TICKET NUMBER OR URL} N/A
Changes
Context for reviewers
Working through the separate dependabot PRs was a bit slow
Testing
Clean run locally:
