Skip to content

[Issue #280]: add node/npm min versions to package.json #340

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 30, 2024

Conversation

rylew1
Copy link
Contributor

@rylew1 rylew1 commented May 29, 2024

Ticket

Resolves #280

Changes

  • add min node/npm version

Testing

  • can't npm install with an older version of node

image

@rylew1 rylew1 added the good first issue Good for newcomers label May 29, 2024
@rylew1 rylew1 added this to the Next.js App Router milestone May 29, 2024
Copy link

github-actions bot commented May 29, 2024

Coverage report for app

St.
Category Percentage Covered / Total
🟢 Statements 93.1% 81/87
🟢 Branches 82.35% 14/17
🟢 Functions 93.33% 14/15
🟢 Lines 93.59% 73/78

Test suite run success

16 tests passing in 5 suites.

Report generated by 🧪jest coverage report action from 131d7db

Co-authored-by: Sawyer Hollenshead <git@sawyerh.com>
@rylew1 rylew1 merged commit 08b47e1 into main May 30, 2024
7 checks passed
@rylew1 rylew1 deleted the rylew/280-add-node-npm-standard-versions branch May 30, 2024 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add engines in package.json to standardize node/npm versions
2 participants