Skip to content

Resolve Storybook build error #98

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 8 commits into from
Closed

Resolve Storybook build error #98

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
973ac38
Test commit to start a PR
mqwebster-nava Mar 24, 2025
7191475
Update Next.js config to support Node.js ECMAScript modules
mqwebster-nava Mar 24, 2025
56dc9ea
Update next.config to use.mjs ensuring ESM use
mqwebster-nava Apr 8, 2025
7b5a6db
Update all app config to leverage Node esm instead of commonJS
mqwebster-nava Apr 8, 2025
b53162b
Revert "Update all app config to leverage Node esm instead of commonJS"
mqwebster-nava Apr 8, 2025
7f177f9
Revert code to original form and use `import.meta.dirname` to resolve…
mqwebster-nava Apr 9, 2025
dce9669
Define Storybook config as .mjs file type to ensure esm use
mqwebster-nava Apr 9, 2025
1b79c6e
Merge branch 'main' into mqwebster/storybook-build-error
mqwebster-nava Apr 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion app/.storybook/main.js → app/.storybook/main.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ const config = {
// https://storybook.js.org/docs/get-started/nextjs
name: "@storybook/nextjs",
options: {
nextConfigPath: path.resolve(__dirname, "../next.config.js"),
nextConfigPath: path.resolve(import.meta.dirname, "../next.config.js"),
builder: {
// lazyCompilation breaks Storybook when running from within Docker
// Google Translate this page for context: https://zenn.dev/yutaosawa/scraps/7764e5f17173d1
Expand Down
2 changes: 1 addition & 1 deletion app/next-env.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,4 +2,4 @@
/// <reference types="next/image-types/global" />

// NOTE: This file should not be edited
// see https://nextjs.org/docs/basic-features/typescript for more information.
// see https://nextjs.org/docs/app/api-reference/config/typescript for more information.
Loading