Skip to content

doc: Promptfoo evaluations instructions: don't use SSL #316

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 3, 2025

Conversation

yoomlam
Copy link
Contributor

@yoomlam yoomlam commented Jun 3, 2025

Ticket

Related to https://navalabs.atlassian.net/browse/DST-985

Changes

Correct instructions: remove SSL from the Chatbot API endpoint URL for preview environments.
Also add more logging to GH Action.

Testing

URLs are shown for traceability

Preview environment for app

♻️ Environment destroyed ♻️

Copy link

github-actions bot commented Jun 3, 2025

Promptfoo Evaluation Results

Success Failure Total Pass Rate
1 14 15 6.67%

View detailed results in Google Sheets

» View eval results «

@yoomlam yoomlam requested a review from Copilot June 3, 2025 18:12
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the documentation for the Chatbot API endpoint URL to remove SSL from preview environment URLs and adds echo commands in the CI workflow for enhanced debugging.

  • Updated the documentation to use an HTTP URL for the Chatbot API endpoint.
  • Added echo commands in the GitHub Actions workflow to print environment variable values.

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
docs/promptfoo-evaluations.md Updated API endpoint URL instructions to remove SSL and use HTTP instead.
.github/workflows/promptfoo-googlesheet-evaluation.yml Added echo commands to output environment variable values for debugging purposes.
Comments suppressed due to low confidence (1)

.github/workflows/promptfoo-googlesheet-evaluation.yml:88

  • Consider whether echoing these URLs in the workflow logs could expose sensitive information. If these environment variable values are confidential, consider masking them or using GitHub's secrets masking features.
echo "Using Google Sheet input URL: $GOOGLE_SHEET_INPUT_URL"

@yoomlam yoomlam requested a review from a team June 3, 2025 18:14
Copy link

github-actions bot commented Jun 3, 2025

Promptfoo Evaluation Results

Success Failure Total Pass Rate
12 3 15 80.00%

View detailed results in Google Sheets

» View eval results «

@yoomlam yoomlam merged commit 2b1ff17 into main Jun 3, 2025
15 of 16 checks passed
@yoomlam yoomlam deleted the yl/fix-promptfoo-md branch June 3, 2025 21:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants