Skip to content

Release 4.2.2 #323

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 19, 2025
Merged
Show file tree
Hide file tree
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions docs/admin/release_notes/version_4.2.md
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,12 @@ Versioning](https://semver.org/spec/v2.0.0.html).
- [#274](https://github.com/nautobot/nautobot-app-device-onboarding/issues/274) - Added TTP Parser support.
- [#274](https://github.com/nautobot/nautobot-app-device-onboarding/issues/274) - Added Sync Device from Network support for Palo Alto Panos.

## [v4.2.2 (2025-02-19)](https://github.com/nautobot/nautobot-app-device-onboarding/releases/tag/v4.2.2)

### Fixed

- [#320](https://github.com/nautobot/nautobot-app-device-onboarding/issues/320) - Fixed app startup crashing nautobot during startup in some cases.

## [v4.2.1 (2025-02-11)](https://github.com/nautobot/nautobot-app-device-onboarding/releases/tag/v4.2.1)

### Fixed
Expand Down
4 changes: 0 additions & 4 deletions nautobot_device_onboarding/constants.py
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
"""Constants for nautobot_device_onboarding app."""

from django.conf import settings
from nautobot.dcim.utils import get_all_network_driver_mappings

NETMIKO_EXTRAS = (
settings.PLUGINS_CONFIG.get("nautobot_plugin_nornir", {})
Expand All @@ -23,9 +22,6 @@
}


# This is used in the new SSoT based jobs.
SUPPORTED_NETWORK_DRIVERS = list(get_all_network_driver_mappings().keys())

# This is used in the new SSoT based jobs. Soon PYATS should be supported.
SUPPORTED_COMMAND_PARSERS = ["textfsm", "ttp"]

Expand Down
6 changes: 3 additions & 3 deletions nautobot_device_onboarding/nornir_plays/command_getter.py
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@
from ntc_templates.parse import parse_output
from ttp import ttp

from nautobot_device_onboarding.constants import SUPPORTED_COMMAND_PARSERS, SUPPORTED_NETWORK_DRIVERS
from nautobot_device_onboarding.constants import SUPPORTED_COMMAND_PARSERS
from nautobot_device_onboarding.nornir_plays.empty_inventory import EmptyInventory
from nautobot_device_onboarding.nornir_plays.inventory_creator import _set_inventory
from nautobot_device_onboarding.nornir_plays.logger import NornirLogger
Expand Down Expand Up @@ -112,7 +112,7 @@ def netmiko_send_commands(
"""Run commands specified in PLATFORM_COMMAND_MAP."""
if not task.host.platform:
return Result(host=task.host, result=f"{task.host.name} has no platform set.", failed=True)
if task.host.platform not in SUPPORTED_NETWORK_DRIVERS or not "cisco_wlc_ssh":
if task.host.platform not in get_all_network_driver_mappings().keys() or not "cisco_wlc_ssh":
return Result(host=task.host, result=f"{task.host.name} has a unsupported platform set.", failed=True)
if not command_getter_yaml_data[task.host.platform].get(command_getter_job):
return Result(
Expand Down Expand Up @@ -354,7 +354,7 @@ def sync_network_data_command_getter(job_result, log_level, kwargs):
"queryset": qs,
"defaults": {
"platform_parsing_info": add_platform_parsing_info(),
"network_driver_mappings": SUPPORTED_NETWORK_DRIVERS,
"network_driver_mappings": list(get_all_network_driver_mappings().keys()),
"sync_vlans": kwargs["sync_vlans"],
"sync_vrfs": kwargs["sync_vrfs"],
"sync_cables": kwargs["sync_cables"],
Expand Down
4 changes: 2 additions & 2 deletions nautobot_device_onboarding/nornir_plays/empty_inventory.py
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
"""Empty Nornir Inventory Plugin."""

from nautobot.dcim.utils import get_all_network_driver_mappings
from nornir.core.inventory import Defaults, Groups, Hosts, Inventory

from nautobot_device_onboarding.constants import SUPPORTED_NETWORK_DRIVERS
from nautobot_device_onboarding.nornir_plays.transform import add_platform_parsing_info


Expand All @@ -15,7 +15,7 @@ def load(self) -> Inventory:
defaults = Defaults(
data={
"platform_parsing_info": add_platform_parsing_info(),
"network_driver_mappings": SUPPORTED_NETWORK_DRIVERS,
"network_driver_mappings": list(get_all_network_driver_mappings().keys()),
}
)
groups = Groups()
Expand Down
3 changes: 1 addition & 2 deletions poetry.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion pyproject.toml
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
[tool.poetry]
name = "nautobot-device-onboarding"
version = "4.2.1"
version = "4.2.2"
description = "A app for Nautobot to easily onboard new devices."
authors = ["Network to Code, LLC <info@networktocode.com>"]
license = "Apache-2.0"
Expand Down
Loading