Skip to content

add missing 'adapter' from logging message #305

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 23, 2025
Merged

Conversation

Dav-C
Copy link
Contributor

@Dav-C Dav-C commented Jan 23, 2025

Fix bug in two logging messages that cause the job to crash if hit. The log messages are only triggered when one of the attributes on the ip_address model is updated and the update fails validated_save.

Copy link
Contributor

@scetron scetron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just needs a change fragment

@Dav-C
Copy link
Contributor Author

Dav-C commented Jan 23, 2025

Looks good, just needs a change fragment

Does this mean it will need an issue too?

@Dav-C Dav-C linked an issue Jan 23, 2025 that may be closed by this pull request
@Dav-C
Copy link
Contributor Author

Dav-C commented Jan 23, 2025

change fragment added

@Dav-C Dav-C merged commit 8e20686 into develop Jan 23, 2025
8 checks passed
@scetron scetron deleted the dcates-fix-logging-bug branch January 24, 2025 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Syntax error in logging message crashes job
2 participants