Skip to content

fixes out of scope logs, fix git repo provides #288

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 16, 2025
Merged

Conversation

jeffkala
Copy link
Contributor

Fixes #277
Fixes #287

Using a __contains method that I still need to test using mysql. Its working for psql as expected.

@jeffkala
Copy link
Contributor Author

Valdiated its working in mysql as well

In [1]: GitRepository.objects.filter(
   ...:             provided_contents__contains="nautobot_device_onboarding.onboarding_command_mappers"
   ...:         )
Out[1]: <RestrictedQuerySet [<GitRepository: command mapper overloads>]>

In [2]: 

In [2]: GitRepository.objects.first().provided_contents
Out[2]: ['extras.job', 'nautobot_device_onboarding.onboarding_command_mappers']

@jeffkala jeffkala marked this pull request as ready for review December 17, 2024 20:27
Copy link
Contributor

@scetron scetron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Leo added a PR covering the git repo issues and added a bit more around it. Please have a look and see if those changes make more sense to include.

@scetron scetron merged commit 9cf1d76 into develop Jan 16, 2025
14 checks passed
@scetron scetron deleted the jlk-gitrepo-fixes branch January 16, 2025 02:23
msheiny pushed a commit to msheiny/nautobot-app-device-onboarding that referenced this pull request Jan 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Out of scopes debug logs show up regardless of the feature usage Git Overrides don't work with multiple provides in the same datasource
3 participants