Update juniper_junos.yml #252
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix hostname parsing for Juniper QFX5100
stockfx0
requested review from
mzbroch,
scetron,
glennmatthews and
chadell
as code owners
jeffkala
reviewed
Oct 11, 2024
| @@ -4,7 +4,7 @@ sync_devices: | |||
| commands: | |||
| - command: "show version | display json" | |||
| parser: "none" | |||
| jpath: '"software-information"[]."host-name"[].data' # yamllint disable-line rule:quoted-strings | |||
| jpath: '"multi-routing-engine-results"[]."multi-routing-engine-item"[]."software-information"[]."host-name"[].data' # yamllint disable-line rule:quoted-strings | |||
There was a problem hiding this comment.
This breaks MX and other not mult-re systems. Take a look at #240 where I'm solving for this issue.
|
Closing out as #240 solved this. It was merged into develop today and new release should be out soon. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix hostname parsing for Juniper QFX5100