Consume the pending messages rather than asserting pending message count. #690
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…unt. This fixes flakiness in test_subscribe_push_bound() where the client-side pending message queue occasionally did not contain all the pending messages from the server by the time the test function inspected the queue, due to a race condition between the task fetching messages from the server and the task running the test function. Resolves nats-io#689. Signed-off-by: Knut Aksel Røysland <knutroy@ifi.uio.no>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes flakiness in
test_subscribe_push_bound()where the client-side pending message queue occasionally did not contain all the pending messages from the server by the time the test function inspected the queue, due to a race condition between the task fetching messages from the server and the task running the test function.Resolves #689.
Signed-off-by: Knut Aksel Røysland knutroy@ifi.uio.no