-
Notifications
You must be signed in to change notification settings - Fork 71
Add support for Filter
and Enrich
for OpenTelemetry activities
#859
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
aradalvand
wants to merge
10
commits into
nats-io:release/2.7
Choose a base branch
from
aradalvand:main
base: release/2.7
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 4 commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
5cc3528
Add support for `Filter` and `Enrich` for OpenTelemetry activities
aradalvand 60508e2
Make `internal` methods in `internal Telemetry` `public`
aradalvand 1613fe2
Fix package versions and whatnot
aradalvand 9232135
Remove `TracerProviderBuilderExtensions`
aradalvand dfb00f5
Include `Deserialize` in the receive activity
aradalvand b278ba6
Revert back accidental change
aradalvand 4bc0f02
Add RequestReplyMode for JetStream (#867)
mtmk b48efb7
Release 2.6.2-preview.1 (#868)
mtmk 7a74497
Add `ParentContext` to `NatsInstrumentationContext`
aradalvand 6f79e2e
Make `GetActivityContext` public to provide the ability to get contex…
aradalvand File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
10 changes: 10 additions & 0 deletions
10
src/NATS.Client.Core/Internal/NatsInstrumentationContext.cs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,10 @@ | ||
namespace NATS.Client.Core.Internal; | ||
|
||
public readonly record struct NatsInstrumentationContext( | ||
string Subject, | ||
NatsHeaders? Headers, | ||
string? ReplyTo, | ||
string? QueueGroup, | ||
long? BodySize, | ||
long? Size, | ||
INatsConnection? Connection); |
26 changes: 26 additions & 0 deletions
26
src/NATS.Client.Core/Internal/NatsInstrumentationOptions.cs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,26 @@ | ||
using System.Diagnostics; | ||
|
||
namespace NATS.Client.Core.Internal; | ||
|
||
/// <summary> | ||
/// Options for the OpenTelemetry instrumentation. | ||
/// </summary> | ||
public sealed class NatsInstrumentationOptions | ||
{ | ||
public static NatsInstrumentationOptions Default => new(); | ||
|
||
/// <summary> | ||
/// Gets or sets a filter function that determines whether or not to collect telemetry on a per request basis. | ||
/// </summary> | ||
/// <remarks> | ||
/// The return value for the filter function is interpreted as follows: | ||
/// - If filter returns `true`, the request is collected. | ||
/// - If filter returns `false` or throws an exception the request is NOT collected. | ||
/// </remarks> | ||
public Func<NatsInstrumentationContext, bool>? Filter { get; set; } | ||
|
||
/// <summary> | ||
/// Gets or sets an action to enrich an Activity. | ||
/// </summary> | ||
public Action<Activity, NatsInstrumentationContext>? Enrich { get; set; } | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.