Swipe menu ng build issue #4
Conversation
There was a problem hiding this comment.
@SeanKelly369 + @farfromrefug - would this commit not break every other angular plugin in the nativescript-community that makes use of this plugin seed?
For example take a look at the install.module in this plugin (which also relies on this angular seed project):
https://github.com/nativescript-community/ui-material-components
There was a problem hiding this comment.
@darklight365. Yes it Will be used in a repos now.
But why would it break ?
There was a problem hiding this comment.
@farfromrefug - The module now hard code includes the ui-collectionview components and does no longer dynamically include the COMPONENTS via the plugins install.module.
Check here:
plugin-seed-demo-ng/src/app/app.module.ts
Line 18 in 8258651
There was a problem hiding this comment.
Prior to this commit the seed project would import the COMPONENTS from the demo-snippets install.module, as seen here:
With this change: the only components included in the angular test project is the ui-collectionview components.
There was a problem hiding this comment.
That was a try to fix build errors on angular demos.
Buy you got it to work in swipemenu without this? I mean did you revert this to have it work in swipemenu?
There was a problem hiding this comment.
No, I did a clean checkout from master (force updated my branch). So the SwipeMenu changes worked with the current ng project seed.
I would need to perform some additional tests to see if reverting the ng seed app.module has any build issues still.
There was a problem hiding this comment.
@farfromrefug - I've made the Angular seed generic again with this PR: #6
The other piece of the puzzle is to correctly export the SwipeMenuComponent in the demo-snippets/ng, PR for that is:
nativescript-community/ui-collectionview#80
cc: @SeanKelly369 for info
3 participants
Now builds and runs successfully