-
Notifications
You must be signed in to change notification settings - Fork 1
DAS-2415: Add units attribute override to SMAP L3 timestamp variables #32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
d079551
DAS-2415: Add units attribute override to SMAP L3 timestamp variables
joeyschultz 903f219
DAS-2415: Fix date on CHANGELOG entry
joeyschultz 1c5a89c
DAS-2415: Add release link to CHANGELOG
joeyschultz 3889dde
Merge branch 'main' into DAS-2415
joeyschultz File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1 +1 @@ | ||
| 1.3.0 | ||
| 1.4.0 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a question and I'm curious. How did you get
2000-01-01 11:58:55.816Zvstime:units = "seconds since 1970-01-01 00:00:00"time:units = "seconds since 2000-01-01 00:00:00"There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From the granule metadata (this was taken from SPL3SMP), we can see that the epoch is J2000 and the UTCepoch matches what we are using.
seconds since 2000-01-01 00:00:00would be the J2000 epoch in TT. :Also, the value we chose matches what the SMAP L4 collections use for their timestamp variables.
Matt did a deeper dive exploring this in the WhatsUpWithTime.ipynb notebook attached to the ticket and confirmed this is the correct value for us to use.