Skip to content

DAS-2419: Restores datatree string behavior #29

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Sep 16, 2025
Merged

DAS-2419: Restores datatree string behavior #29

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
a0c018d
DAS-2411: removes h5netcdf and bumps xarray
flamingbear Sep 4, 2025
5599716
DAS-2411: Clean up words in changelog
flamingbear Sep 4, 2025
d1053ba
Merge remote-tracking branch 'origin/main' into mhs/DAS-2411-redux/up…
flamingbear Sep 10, 2025
f4d1778
DAS-2419: Allow string concat by Xarray.
flamingbear Sep 12, 2025
a80ab4f
DAS-2419: update CHANGELOG and version.
flamingbear Sep 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,13 @@ All notable changes to this project will be documented in this file.
The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.1.0/),
and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).

## [v1.3.0] - 2025-09-16

### Changed

- Changes parameters when opening xarray.datatree so that strings are decoded from characters properly.
- Internally updates xarray and removes h5netcdf dependencies.

## [v1.2.0] - 2025-09-02

### Changed
Expand Down Expand Up @@ -86,6 +93,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
for a variable as specified via an `earthdata-varinfo` configuration file.
- Initial repository setup with utility scripts and Dockerfiles.

[v1.3.0]: https://github.com/nasa/harmony-metadata-annotator/releases/tag/1.3.0
[v1.2.0]: https://github.com/nasa/harmony-metadata-annotator/releases/tag/1.2.0
[v1.1.0]: https://github.com/nasa/harmony-metadata-annotator/releases/tag/1.1.0
[v1.0.4]: https://github.com/nasa/harmony-metadata-annotator/releases/tag/1.0.4
Expand Down
2 changes: 1 addition & 1 deletion docker/service_version.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
1.2.0
1.3.0
4 changes: 3 additions & 1 deletion metadata_annotator/annotate.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,8 +78,10 @@ def amend_in_file_metadata(
with xr.open_datatree(
input_file_name,
decode_times=False,
decode_timedelta=False,
decode_coords=False,
decode_cf=False,
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So we shouldn't be using this flag if we want to do any decoding. if this is false, all the other flags are ignored and also discarded. The current set of flags is probably overkill, but it is explicit and doing what we want. concatting strings and leaving everything else alone

concat_characters=True,
use_cftime=False,
mask_and_scale=False,
) as datatree:
# Update all pre-existing variables or groups with metadata overrides including
Expand Down
3 changes: 1 addition & 2 deletions requirements.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,5 +3,4 @@ cftime ~= 1.6.4
earthdata-varinfo ~= 3.0.2
harmony-service-lib ~= 2.5.0
netCDF4 ~= 1.6.5
xarray == 2025.8.0
h5netcdf == 1.6.4
xarray == 2025.9.0