Skip to content

165 fix failing ci #166

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Nov 13, 2024
Merged

165 fix failing ci #166

merged 5 commits into from
Nov 13, 2024

Conversation

@asgibson
Copy link
Contributor

Fixes failing Actions due to conda usage. It is now using standard available actions and pip.

In addition, due to the pip change, several requirements files were built to facilitate both automation and user requirements needs.

@asgibson
Attempt to run CI unit tests without conda
cad6d3a 
Additionally added requirements.txt
@asgibson
Updated linting to not use conda
281b4fd
@asgibson
Break up requirements
13f7828 
Requirements now in sections
  run - packages necessary for running onair
  unittest - packages for running unit tests
  lint - packages for linting
@asgibson
Updated requirements files and usage by Actions
0457d32 
Multiple requirements files
  -run, only what is necessary to run all provided configs
  -unittest, only the testing packages
  -lint, only the linting packages
  -dev, all requirements for developers (-run, -unittest, -lint)
  no designation, requirements.txt (-run and -unittest)
Worflow files
  lint now uses just -lint
  unit-test uses requirements.txt
@asgibson asgibson added bug Something isn't working unit test Unit tests need fixed or added convention Repository coding and documentation standards urgent needs immediate attention labels Nov 13, 2024
@asgibson asgibson linked an issue Nov 13, 2024 that may be closed by this pull request
Fix failing CI #165
Closed
@asgibson asgibson mentioned this pull request Nov 13, 2024
Merged
the-other-james
the-other-james approved these changes Nov 13, 2024
View reviewed changes
Copy link
Contributor

@the-other-james the-other-james left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this! I updated the Dockerfile to use Python 3.11 and install dependencies from the new requirements files.

@asgibson asgibson self-assigned this Nov 13, 2024
@asgibson asgibson merged commit d75f1c1 into main Nov 13, 2024
20 checks passed
@asgibson asgibson deleted the 165-fix-failing-ci branch November 13, 2024 21:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@the-other-james the-other-james the-other-james approved these changes

Assignees

@asgibson asgibson

Labels

bug Something isn't working convention Repository coding and documentation standards unit test Unit tests need fixed or added urgent needs immediate attention

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Fix failing CI

2 participants

@asgibson @the-other-james