Skip to content

Conversation

pulsastrix
Copy link
Member

This fixes the build issues caused by the old mbedTLS version provided by mbedtls-sys-auto, see #49 for issue description.

Regardless of whether we want to keep support for mbedtls-sys-auto at all, we can disable using it in the CI pipeline for now and use a system-provided version instead.

@pulsastrix pulsastrix requested a review from JKRhb April 1, 2025 16:11
@pulsastrix pulsastrix self-assigned this Apr 1, 2025
@pulsastrix pulsastrix added the bugfix Fix for a bug label Apr 1, 2025
Copy link

github-actions bot commented Apr 1, 2025

Workflow Status Report

Generated for commit c5187ab on Wed Apr 2 17:55:46 UTC 2025.

Test and Analyze
Docs, Coverage Report and PR Updates

In case of failure, clippy warnings and rustfmt changes (if any) will be indicated as CI check warnings in the file comparison view.

Documentation: Read Online Download

Coverage Report: Read Online Download

Note: Online versions of documentation and coverage reports may not be available indefinitely, especially after the pull request was merged.

Code Coverage Report

Coverage

Coverage target is 80%.

Expand to view coverage statistics
file coverage covered missed_lines
libcoap-sys/src/lib.rs 83.27% 209 / 251 370-381, 489-492, 500, 527-544, 669-672, 756-759
libcoap/src/context.rs 58.82% 230 / 391 110, 171-216, 226-233, 250, 279, 326-329, 363, 378-380, 417-433, 467, 472, 488, 496-658
libcoap/src/crypto/pki_rpk/key.rs 56.67% 51 / 90 179-218, 242-250, 252-255, 261-263
libcoap/src/crypto/pki_rpk/mod.rs 22.81% 99 / 434 36-275, 454-486, 507-605, 613, 616, 650-668, 678-680, 685-687, 692-694, 755, 767-903
libcoap/src/crypto/pki_rpk/pki.rs 78.08% 114 / 146 90-149, 302-315
libcoap/src/crypto/pki_rpk/rpk.rs 72.60% 53 / 73 68-98, 160-171
libcoap/src/crypto/psk/client.rs 45.59% 62 / 136 71-75, 83, 106-192, 234-242, 269-271, 276-278, 306-338
libcoap/src/crypto/psk/key.rs 61.46% 59 / 96 42-49, 163-205
libcoap/src/crypto/psk/mod.rs 0.00% 0 / 33 30-96
libcoap/src/crypto/psk/server.rs 30.54% 51 / 167 69-88, 96, 99, 116-119, 145-147, 152-154, 159-161, 189-234, 255, 271-396
libcoap/src/error.rs 0.00% 0 / 6 104-184
libcoap/src/event.rs 29.73% 11 / 37 36-168
libcoap/src/lib.rs 0.00% 0 / 64 62-165
libcoap/src/mem.rs 72.89% 121 / 166 148-163, 196-198, 210-212, 280, 296-298, 319-324, 353-355, 369, 381-393, 454-456, 473, 481-488, 507, 527, 531
libcoap/src/message/mod.rs 58.46% 190 / 325 105-108, 110-131, 139-145, 147-168, 172, 174, 176, 208, 210, 213-222, 225-243, 245-249, 265-275, 295-302, 398, 441, 447, 478, 488-491, 497-499, 506, 511-523, 529, 549-551, 561-563
libcoap/src/message/request.rs 34.12% 101 / 296 51, 68-202, 228-256, 264-365, 371-375, 380-381, 383-386, 389, 395-401, 430-432, 436, 439-441, 444-446, 449, 452, 455, 458, 461, 472-479
libcoap/src/message/response.rs 22.17% 45 / 203 36-160, 165, 168, 171, 174, 177, 195-325, 329-334, 360
libcoap/src/prng.rs 55.41% 41 / 74 66, 78-116, 139-149, 196
libcoap/src/protocol.rs 35.88% 61 / 170 164-166, 171-176, 178-193, 195-196, 203-208, 210-225, 227-228, 248-287, 308, 322-324, 369-374, 383-388, 444-469, 475-488, 520, 522
libcoap/src/resource.rs 65.65% 172 / 262 62, 94-96, 171-176, 183-208, 214-219, 249, 266-288, 300-303, 319-339, 351-354, 387-396, 529-531
libcoap/src/session/client.rs 90.20% 138 / 153 164, 191, 223, 231-233, 239-241, 288-294
libcoap/src/session/mod.rs 38.14% 111 / 291 62-74, 105, 115-230, 240-285, 294-310, 319-330, 359, 363, 395-415, 437, 445, 477, 484, 502-508, 583, 589
libcoap/src/session/server.rs 82.05% 64 / 78 75-77, 81, 152, 162-164, 179, 194-200
libcoap/src/transport.rs 70.97% 22 / 31 29-36, 55
libcoap/src/types.rs 55.60% 313 / 563 71-125, 131-160, 210-223, 241-243, 253-265, 272-278, 284-286, 295, 562, 571, 583, 610, 636-705, 758, 803-824, 845-847, 863-868, 879-964
libcoap/tests/common/dtls.rs 94.34% 50 / 53 49, 54-55
libcoap/tests/common/mod.rs 93.68% 89 / 95 85-88, 92, 126
libcoap/tests/dtls_pki_client_server_test.rs 100.00% 82 / 82
libcoap/tests/dtls_psk_client_server_test.rs 100.00% 26 / 26
libcoap/tests/dtls_rpk_client_server_test.rs 100.00% 7 / 7
libcoap/tests/tcp_client_server_test.rs 100.00% 22 / 22
libcoap/tests/udp_client_server_test.rs 100.00% 22 / 22

Total coverage: 54.02%

@pulsastrix
Copy link
Member Author

Hm, I guess for documentation builds we have to work around the CMake issue by forcing CMake to ignore the version issue.

The only other alternative would be to specify all features to enable manually, which would be a very long list that would probably go out of sync with the actual feature list soon.

However, for the actual test run, mbedtls-sys-auto has now been disabled.

@pulsastrix pulsastrix force-pushed the ci_disable_mbedtls_sys_auto branch from bf5ab96 to c5187ab Compare April 2, 2025 17:52
@pulsastrix pulsastrix enabled auto-merge April 2, 2025 17:52
@pulsastrix pulsastrix merged commit 28c5c60 into main Apr 2, 2025
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugfix Fix for a bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants