Rework of DTLS code, add DTLS PKI/RPK #177
Annotations
11 warnings
[clippy (libcoap-rs)] libcoap/src/context.rs#L18:
libcoap/src/context.rs#L18
warning: unused import: `coap_context_set_pki_root_cas`
--> libcoap/src/context.rs:18:5
|
18 | coap_context_set_pki_root_cas, coap_context_set_session_timeout, coap_context_t, coap_event_t, coap_free_context,
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= note: `#[warn(unused_imports)]` on by default
|
[clippy (libcoap-rs)] libcoap/src/context.rs#L23:
libcoap/src/context.rs#L23
warning: unused import: `std::ffi::CString`
--> libcoap/src/context.rs:23:5
|
23 | use std::ffi::CString;
| ^^^^^^^^^^^^^^^^^
|
[clippy (libcoap-rs)] libcoap/src/context.rs#L24:
libcoap/src/context.rs#L24
warning: unused import: `std::path::Path`
--> libcoap/src/context.rs:24:5
|
24 | use std::path::Path;
| ^^^^^^^^^^^^^^^
|
[clippy (libcoap-rs)] libcoap/src/context.rs#L45:
libcoap/src/context.rs#L45
warning: unused import: `std::os::unix::ffi::OsStrExt`
--> libcoap/src/context.rs:45:5
|
45 | use std::os::unix::ffi::OsStrExt;
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
[clippy (libcoap-rs)] libcoap/src/crypto/psk/client.rs#L115:
libcoap/src/crypto/psk/client.rs#L115
warning: use of `.then_some(..).unwrap_or(..)` can be written more clearly with `if .. else ..`
--> libcoap/src/crypto/psk/client.rs:115:36
|
115 | self.ctx.raw_cfg.use_cid = use_cid.then_some(1).unwrap_or(0);
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `if use_cid { 1 } else { 0 }`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#obfuscated_if_else
= note: `#[warn(clippy::obfuscated_if_else)]` on by default
|
[clippy (libcoap-rs)] libcoap/src/crypto/psk/key.rs#L166:
libcoap/src/crypto/psk/key.rs#L166
warning: useless conversion to the same type: `std::boxed::Box<[u8]>`
--> libcoap/src/crypto/psk/key.rs:166:19
|
166 | data: value.into(),
| ^^^^^^^^^^^^ help: consider removing `.into()`: `value`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
|
[clippy (libcoap-rs)] libcoap/src/crypto/psk/server.rs#L290:
libcoap/src/crypto/psk/server.rs#L290
warning: derefed type is same as origin
--> libcoap/src/crypto/psk/server.rs:290:23
|
290 | .find(|k| k.identity().as_deref().is_some_and(|kid| kid == identity))
| ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `k.identity()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_option_as_deref
= note: `#[warn(clippy::needless_option_as_deref)]` on by default
|
[clippy (libcoap-rs)] libcoap/src/crypto/psk/server.rs#L318:
libcoap/src/crypto/psk/server.rs#L318
warning: this call to `as_ref` does nothing
--> libcoap/src/crypto/psk/server.rs:318:20
|
318 | let keys = self.as_ref();
| ^^^^^^^^^^^^^ help: try: `self`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_asref
= note: `#[warn(clippy::useless_asref)]` on by default
|
[clippy (libcoap-rs)] libcoap/src/types.rs#L779:
libcoap/src/types.rs#L779
warning: using `libc::strlen` on a `CString` or `CStr` value
--> libcoap/src/types.rs:779:17
|
779 | libc::strlen(uri.uri_str.0.as_ptr()),
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `uri.uri_str.0.as_bytes().len()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#strlen_on_c_strings
= note: `#[warn(clippy::strlen_on_c_strings)]` on by default
|
lint (libcoap-rs)
The following actions use a deprecated Node.js version and will be forced to run on node20: giraffate/clippy-action@main. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
lint (libcoap-sys)
The following actions use a deprecated Node.js version and will be forced to run on node20: giraffate/clippy-action@main. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|