Process completed with exit code 101.

Process completed with exit code 101.

Process completed with exit code 101.

reviewdog exited with status code: 1

Process completed with exit code 101.

The following actions use a deprecated Node.js version and will be forced to run on node20: giraffate/clippy-action@main. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/

warning: unused import: `std::fmt::Debug` --> libcoap/src/crypto/psk/mod.rs:9:5 | 9 | use std::fmt::Debug; | ^^^^^^^^^^^^^^^ | = note: `#[warn(unused_imports)]` on by default

warning: function `boxed_slice_into_parts` is never used --> libcoap/src/mem.rs:534:15 | 534 | pub(crate) fn boxed_slice_into_parts<T>(data: Box<[T]>) -> (NonNull<T>, usize) { | ^^^^^^^^^^^^^^^^^^^^^^ | = note: `#[warn(dead_code)]` on by default

warning: function `boxed_slice_from_raw_parts` is never used --> libcoap/src/mem.rs:540:22 | 540 | pub(crate) unsafe fn boxed_slice_from_raw_parts<T>(data: *mut T, len: usize) -> Box<[T]> { | ^^^^^^^^^^^^^^^^^^^^^^^^^^

warning: function `try_boxed_slice_from_raw_parts` is never used --> libcoap/src/mem.rs:544:22 | 544 | pub(crate) unsafe fn try_boxed_slice_from_raw_parts<T>(data: *mut T, len: usize) -> Option<Box<[T]>> { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

warning: use of `.then_some(..).unwrap_or(..)` can be written more clearly with `if .. else ..` --> libcoap/src/crypto/psk/client.rs:46:37 | 46 | self.ctx.raw_cfg.ec_jpake = ec_jpake.then_some(1).unwrap_or(0); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `if ec_jpake { 1 } else { 0 }` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#obfuscated_if_else = note: `#[warn(clippy::obfuscated_if_else)]` on by default

warning: use of `.then_some(..).unwrap_or(..)` can be written more clearly with `if .. else ..` --> libcoap/src/crypto/psk/client.rs:52:36 | 52 | self.ctx.raw_cfg.use_cid = use_cid.then_some(1).unwrap_or(0); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `if use_cid { 1 } else { 0 }` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#obfuscated_if_else

warning: this lifetime isn't used in the impl --> libcoap/src/crypto/psk/client.rs:214:6 | 214 | impl<'a, T: Debug> ClientPskHintKeyProvider for T | ^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes = note: `#[warn(clippy::extra_unused_lifetimes)]` on by default

warning: derefed type is same as origin --> libcoap/src/crypto/psk/client.rs:220:39 | 220 | if identity_hint.is_none() || key.identity().as_deref() == identity_hint { | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `key.identity()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_option_as_deref = note: `#[warn(clippy::needless_option_as_deref)]` on by default

warning: casting the result of `from_raw_parts_mut` to *mut [u8] --> libcoap/src/crypto/psk/key.rs:117:43 | 117 | let data = unsafe { Box::from_raw(std::slice::from_raw_parts_mut(key.s as *mut u8, key.length) as *mut [u8]) }; | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace with: `core::ptr::slice_from_raw_parts_mut(key.s as *mut u8, key.length)` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_slice_from_raw_parts = note: `#[warn(clippy::cast_slice_from_raw_parts)]` on by default

warning: useless conversion to the same type: `std::boxed::Box<[u8]>` --> libcoap/src/crypto/psk/key.rs:126:19 | 126 | data: value.into(), | ^^^^^^^^^^^^ help: consider removing `.into()`: `value` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion

warning: use of `.then_some(..).unwrap_or(..)` can be written more clearly with `if .. else ..` --> libcoap/src/crypto/psk/server.rs:46:37 | 46 | self.ctx.raw_cfg.ec_jpake = ec_jpake.then_some(1).unwrap_or(0); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `if ec_jpake { 1 } else { 0 }` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#obfuscated_if_else

warning: derefed type is same as origin --> libcoap/src/crypto/psk/server.rs:229:23 | 229 | .find(|k| k.identity().as_deref().is_some_and(|kid| kid == identity)) | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `k.identity()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_option_as_deref

warning: this call to `as_ref` does nothing --> libcoap/src/crypto/psk/server.rs:248:20 | 248 | let keys = self.as_ref(); | ^^^^^^^^^^^^^ help: try: `self` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_asref = note: `#[warn(clippy::useless_asref)]` on by default

warning: using `libc::strlen` on a `CString` or `CStr` value --> libcoap/src/types.rs:761:17 | 761 | libc::strlen(uri.uri_str.0.as_ptr()), | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `uri.uri_str.0.as_bytes().len()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#strlen_on_c_strings = note: `#[warn(clippy::strlen_on_c_strings)]` on by default