Skip to content

Documentation fixes for Microsoft compatibility #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 12, 2025

Conversation

jbinder
Copy link
Contributor

@jbinder jbinder commented Mar 10, 2025

Fixes the example for generating hashes, which could lead to obscure JavaScript errors if calculated, see here.

Adds instructions to protect WOPI routes, to ensure security for the exposed resources.

@nagi1 nagi1 requested a review from Copilot March 12, 2025 09:48
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes a few documentation errors and improves the example for generating hashes to avoid JavaScript errors. It also adds instructions to protect WOPI routes for enhanced security.

  • Fixes a typo in a header (“Retrive” → “Retrieve”)
  • Corrects misspellings in hash calculation comments (e.g. “carefull” → “careful”)
  • Adds a section with security instructions for WOPI endpoints

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
docs/docs/getting-started/installation.md Fixed header typo and added security instructions section
docs/docs/getting-started/document-manager.md Corrected typos in comments and updated the hash generation example

@nagi1 nagi1 merged commit 7ff25a9 into nagi1:main Mar 12, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants