feat(core): Add config to override default database ping interval and default idle connection timeout #15764
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅ 📢 Thoughts on this report? Let us know! |
n8n-assistant
bot
added
core
guillaumejacquart
force-pushed
the
pay-2846-community-issue-endpoint-healthzreadiness-returning-statusok
branch
2 times, most recently
from
f60889a to
2f1db7a
Compare
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
There was a problem hiding this comment.
cubic reviewed 6 files and found no issues. Review PR in cubic.dev.
…e connection timeout of postgres database (to release a connection from the pool)
guillaumejacquart
force-pushed
the
pay-2846-community-issue-endpoint-healthzreadiness-returning-statusok
branch
from
2f1db7a to
53c8ce3
Compare
Workflow Test Results 📊 🔴 1 Failed,
|
| Workflow ID | Workflow Name | Reason |
|---|---|---|
| 237 | BasicLLMChain:AzureChat | Workflow contains 1 deleted data. |
⚠️ Warnings (1)
| Workflow ID | Workflow Name | Reason |
|---|---|---|
| 257 | Agent:auto-fix:anthropic | Workflow contains new data that previously did not exist. |
|
✅ All Cypress E2E specs passed |
guillaumejacquart
requested review from
a team,
alexgrozav and
netroy
and removed request for
a team
netroy
approved these changes
Jun 3, 2025
| @@ -1,4 +1,5 @@ | |||
| import { inTest } from '@n8n/backend-common'; | |||
| import { DatabaseConfig } from '@n8n/config'; | |||
There was a problem hiding this comment.
If we are going to import this directly, might as well move DatabaseConfig from @n8n/config into this same folder.
in a separate PR of-course.
| this.pingTimer = setTimeout(async () => await this.ping(), 2000); | ||
| this.pingTimer = setTimeout( | ||
| async () => await this.ping(), | ||
| this.databaseConfig.pingIntervalSeconds * Time.seconds.toMilliseconds, |
There was a problem hiding this comment.
we could really benefit from a Duration type to make all the timeouts a tiny bit more type-safe.
Workflow Test Results 📊 🔴 2 Failed,
|
| Workflow ID | Workflow Name | Reason |
|---|---|---|
| 237 | BasicLLMChain:AzureChat | Workflow contains 1 deleted data. |
| 84 | Matrix:Room:create invite kick leave:RoomMember:ge... | Too Many Requests on node Matrix2 |
⚠️ Warnings (4)
| Workflow ID | Workflow Name | Reason |
|---|---|---|
| 35 | Slack:User:getPresence info:UserProfile:get update... | Workflow contains new data that previously did not exist. |
| 48 | Asana:Project:getAll get:Task:create update move g... | Workflow contains new data that previously did not exist. |
| 53 | ConvertKit:CustomField:create getAll update delete... | Workflow contains new data that previously did not exist. |
| 257 | Agent:auto-fix:anthropic | Workflow contains new data that previously did not exist. |
|
✅ All Cypress E2E specs passed |
netroy
deleted the
pay-2846-community-issue-endpoint-healthzreadiness-returning-statusok
branch
Alexandero89
pushed a commit
to Alexandero89/n8n
that referenced
this pull request
Jun 4, 2025
… default idle connection timeout (n8n-io#15764)
Alexandero89
pushed a commit
to Alexandero89/n8n
that referenced
this pull request
Jun 4, 2025
… default idle connection timeout (n8n-io#15764)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When using postgres or mysql/mariadb as database, typeorm uses a connection pool. When the dabatase password for the current user changes (password rotation for instance), the db-connection ping function that checks the liveness of the db will most likely re-use an existing connection from the pool, that is kept and not refresh when user db password changes. Thus the ping will succeeded, and n8n will still be up even though new connection from the pool will fail.
To fix that, I suggest to offer the possibility to change the database ping interval as well as the idle connection timeout for a connection in the pool.
That way, a user could setup the idle connection timeout to be less than the ping connection timeout, so that a new connection is created for each ping, thus re-validating the credentials.
We should see later if we want this behavior (each ping connection to be new) to be by default.
Related Linear tickets, Github issues, and Community forum posts
https://linear.app/n8n/issue/PAY-2846/community-issue-endpoint-healthzreadiness-returning-statusok-even-when
#15480
Review / Merge checklist
release/backport(if the PR is an urgent fix that needs to be backported)