Skip to content

feat(iroh,iroh-relay)!: Use stride instead of custom split protocol, send ECN bits #3389

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 85 commits into from
Jul 18, 2025
Merged

feat(iroh,iroh-relay)!: Use stride instead of custom split protocol, send ECN bits #3389

merged 85 commits into from
Jul 18, 2025

Conversation

matheus23
Copy link
Member

@matheus23 matheus23 commented Jul 14, 2025 •
edited
Loading

Description

Based on #3331

  • Enable doing active queue management in relays in the future (we now send ECN bits with messages!)
  • Avoid doing our own packet merging & splitting, instead just forward quinn's Transmit format (bytes + optional stride)

Breaking Changes

The relay wire protocol changed: All relayed messages now contain at least an additional ECN byte.
They might be accidentally compatible when GSO is not enabled, but they're likely not.
This means this version of iroh can't connect to older relays or older clients on newer relays.

  • ClientToRelayMsg::SendPacket was removed in favor of ClientToRelayMsg::Datagrams
  • RelayToClientMsg::ReceivedPacket was removed in favor of RelayToClientMsg::Datagrams
  • FrameType has changed variants:
    • SendPacket and RecvPacket were removed
    • ClientToRelayDatagram and ClientToRelayDatagramBatch were added
    • RelayToClientDatagram and RelayToClientDatagramBatch were added

Change checklist

  • Self-review.
  • Documentation updates following the style guide, if relevant.
  • Tests if relevant.
  • All breaking changes documented.
    • List all breaking changes in the above "Breaking Changes" section.

matheus23 added 30 commits May 30, 2025 15:28
@matheus23
Separate code path for websocket handshake
6aaed21
@matheus23
Implement full handshake protocol for websocket transport only
55fd3b2
@matheus23
WIP
3f52da0
@matheus23
WIP
db787e1
@matheus23
Test & fix ClientInfo serialization round-trip
20f08c9
@matheus23
Rename handshake stuff, implement key-export based verification on se…
5cb2248 
…rver side
@matheus23
Introduce FrameType enum
04d34e3
@matheus23
Fix typo
41f5f3f
@matheus23
Merge branch 'main' into matheus23/relay-handshake-2
f6bd7ab
@matheus23
Fix merge
eeebc80
@matheus23
(WIP) remove legacy relay protocol path
140e967
@matheus23
cargo make format
ae67e9c
@matheus23
WIP
0433a33
@matheus23
WIP
ab193ef
@matheus23
Our own rate limiter
6ada3d6
@matheus23
Remove unused code
cfe4e4d
@matheus23
Restructure tests, remove unused code
bb27d3d
@matheus23
Remove unused frames
9a92b0d
@matheus23
Remove Frame, ReceivedMessage and SendMessage in favor of `Serv…
8a2ebd5 
…erToClientMsg` and `ClientToServerMsg`
@matheus23
Remove Option from ServerToClientMsg::Health
87c68a3
@matheus23
Fix iroh type
ae844ab
@matheus23
Deduplicate FrameType
521bdfa
@matheus23
Remove Protocol enum
0dda03e
@matheus23
Fix snapshot tests
bd8f56b
@matheus23
Move handshake & send/recv common code to relay.rs (rename relay.rs -…
35df94d 
…> send_recv.rs)
@matheus23
Merge branch 'main' into matheus23/relay-handshake-2
866fed0
@matheus23
Resolve warnings
7a7c09c
@matheus23
cargo make format
fe9641b
@matheus23
Send ECN bits and use stride instead of custom split protocol
7a5550a
@matheus23
Fix iroh-relay tests
f254fa4
@matheus23 matheus23 self-assigned this Jul 14, 2025
@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 14, 2025 •
edited
Loading

Documentation for this PR has been generated and is available at: https://n0-computer.github.io/iroh/pr/3389/docs/iroh/

Last updated: 2025-07-18T08:03:40Z

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 14, 2025 •
edited
Loading

Netsim report & logs for this PR have been generated and is available at: LOGS
This report will remain available for 3 days.

Last updated for commit: 9dee2af

@matheus23 matheus23 changed the base branch from matheus23/relay-handshake-3 to matheus23/relay-handshake-2 July 14, 2025 13:39
@matheus23 matheus23 mentioned this pull request Jul 14, 2025
Merged
4 tasks
@n0bot n0bot bot added this to iroh Jul 14, 2025
@github-project-automation github-project-automation bot moved this to 🏗 In progress in iroh Jul 14, 2025
@matheus23 matheus23 force-pushed the matheus23/relay-efficient-gso branch from 184cff8 to 3a6d751 Compare July 14, 2025 14:29
flub
flub approved these changes Jul 15, 2025
View reviewed changes
Base automatically changed from matheus23/relay-handshake-2 to main July 16, 2025 10:24
@matheus23 matheus23 marked this pull request as ready for review July 18, 2025 08:00
flub
flub approved these changes Jul 18, 2025
View reviewed changes
Copy link
Contributor

@flub flub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@matheus23 matheus23 added this pull request to the merge queue Jul 18, 2025
Merged via the queue into main with commit f3fd988 Jul 18, 2025
29 of 30 checks passed
@github-project-automation github-project-automation bot moved this from 🏗 In progress to ✅ Done in iroh Jul 18, 2025
@dignifiedquire dignifiedquire deleted the matheus23/relay-efficient-gso branch July 18, 2025 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flub flub flub approved these changes

Assignees

@matheus23 matheus23

Labels
None yet
Projects
iroh
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@matheus23 @flub