-
Notifications
You must be signed in to change notification settings - Fork 261
feat!: update to edition 2024 and update deps to latest #3386
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Documentation for this PR has been generated and is available at: https://n0-computer.github.io/iroh/pr/3386/docs/iroh/ Last updated: 2025-07-16T10:44:01Z |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If it works, it works, I guess.
But tbh I would prefer to use 'static wherever possible to indicate that the returned thing is fully self-contained.
Especially this one is probably redundant:
mpl Iterator<Item = hickory_resolver::proto::rr::Record> + 'static + use<>
It's an iterator that does not have a reference on any of the lifetimes of the input parameters. Why is the use<> needed then?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now I know the intention from the other PR: all the Cargo.toml files in this PR also don't bump the edition.
There are lots of places where we have fn foo(&self) -> impl Bar + use<>. As far as I can see all these places can be just replaced with -> impl Bar + 'static, which for me reads much more natural than the weird |
But asfaiu that does not mean the same thing though |
Not in general, but in this case? The returned thing is supposed to have no lifetime dependencies on any of the parameters that are passed by reference (which is just &self). So how is that not the same as 'static? What other source of lifetimes other than the args is there? |
|
If you just use 'static everywhere instead of I will have to try out in play.rust-lang.org what the rules are from calling use<> from 'static or otherwise. |
asfaict |
93c5b68
to
88d4628
Compare
Description
Updates dependencies where possible.
Closes #3385
Depends on
Breaking Changes
All crates are now
edition2024