Skip to content

Commit b30958c

Browse files
committed
Simplify Boolean Expression Renderer
1 parent 97e22d2 commit b30958c

File tree

4 files changed

+15
-15
lines changed

4 files changed

+15
-15
lines changed

src/main/java/org/mybatis/dynamic/sql/common/AbstractBooleanExpressionRenderer.java

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -28,13 +28,13 @@
2828
import org.mybatis.dynamic.sql.where.render.CriterionRenderer;
2929
import org.mybatis.dynamic.sql.where.render.RenderedCriterion;
3030

31-
public abstract class AbstractBooleanExpressionRenderer<M extends AbstractBooleanExpressionModel> {
32-
protected final M model;
31+
public abstract class AbstractBooleanExpressionRenderer {
32+
protected final AbstractBooleanExpressionModel model;
3333
private final String prefix;
3434
private final CriterionRenderer criterionRenderer;
3535
protected final RenderingContext renderingContext;
3636

37-
protected AbstractBooleanExpressionRenderer(String prefix, AbstractBuilder<M, ?> builder) {
37+
protected AbstractBooleanExpressionRenderer(String prefix, AbstractBuilder<?> builder) {
3838
model = Objects.requireNonNull(builder.model);
3939
this.prefix = Objects.requireNonNull(prefix);
4040
renderingContext = Objects.requireNonNull(builder.renderingContext);
@@ -82,11 +82,11 @@ private String addPrefix(String fragment) {
8282
return spaceAfter(prefix) + fragment;
8383
}
8484

85-
public abstract static class AbstractBuilder<M, B extends AbstractBuilder<M, B>> {
86-
private final M model;
85+
public abstract static class AbstractBuilder<B extends AbstractBuilder<B>> {
86+
private final AbstractBooleanExpressionModel model;
8787
private RenderingContext renderingContext;
8888

89-
protected AbstractBuilder(M model) {
89+
protected AbstractBuilder(AbstractBooleanExpressionModel model) {
9090
this.model = model;
9191
}
9292

src/main/java/org/mybatis/dynamic/sql/select/render/HavingRenderer.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@
1818
import org.mybatis.dynamic.sql.common.AbstractBooleanExpressionRenderer;
1919
import org.mybatis.dynamic.sql.select.HavingModel;
2020

21-
public class HavingRenderer extends AbstractBooleanExpressionRenderer<HavingModel> {
21+
public class HavingRenderer extends AbstractBooleanExpressionRenderer {
2222
private HavingRenderer(Builder builder) {
2323
super("having", builder); //$NON-NLS-1$
2424
}
@@ -27,7 +27,7 @@ public static Builder withHavingModel(HavingModel havingModel) {
2727
return new Builder(havingModel);
2828
}
2929

30-
public static class Builder extends AbstractBuilder<HavingModel, Builder> {
30+
public static class Builder extends AbstractBuilder<Builder> {
3131
public Builder(HavingModel havingModel) {
3232
super(havingModel);
3333
}

src/main/java/org/mybatis/dynamic/sql/select/render/SearchedCaseWhenConditionRenderer.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -18,13 +18,13 @@
1818
import org.mybatis.dynamic.sql.common.AbstractBooleanExpressionRenderer;
1919
import org.mybatis.dynamic.sql.select.caseexpression.SearchedCaseWhenCondition;
2020

21-
public class SearchedCaseWhenConditionRenderer extends AbstractBooleanExpressionRenderer<SearchedCaseWhenCondition> {
21+
public class SearchedCaseWhenConditionRenderer extends AbstractBooleanExpressionRenderer {
2222
protected SearchedCaseWhenConditionRenderer(Builder builder) {
2323
super("when", builder);
2424
}
2525

2626
public static class Builder
27-
extends AbstractBooleanExpressionRenderer.AbstractBuilder<SearchedCaseWhenCondition, Builder> {
27+
extends AbstractBooleanExpressionRenderer.AbstractBuilder<Builder> {
2828

2929
protected Builder(SearchedCaseWhenCondition model) {
3030
super(model);

src/main/java/org/mybatis/dynamic/sql/where/render/WhereRenderer.java

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -17,12 +17,12 @@
1717

1818
import java.util.Optional;
1919

20+
import org.mybatis.dynamic.sql.common.AbstractBooleanExpressionModel;
2021
import org.mybatis.dynamic.sql.common.AbstractBooleanExpressionRenderer;
2122
import org.mybatis.dynamic.sql.exception.NonRenderingWhereClauseException;
2223
import org.mybatis.dynamic.sql.util.FragmentAndParameters;
23-
import org.mybatis.dynamic.sql.where.WhereModel;
2424

25-
public class WhereRenderer extends AbstractBooleanExpressionRenderer<WhereModel> {
25+
public class WhereRenderer extends AbstractBooleanExpressionRenderer {
2626
private WhereRenderer(Builder builder) {
2727
super("where", builder); //$NON-NLS-1$
2828
}
@@ -38,12 +38,12 @@ public Optional<FragmentAndParameters> render() {
3838
}
3939
}
4040

41-
public static Builder withWhereModel(WhereModel whereModel) {
41+
public static Builder withWhereModel(AbstractBooleanExpressionModel whereModel) {
4242
return new Builder(whereModel);
4343
}
4444

45-
public static class Builder extends AbstractBuilder<WhereModel, Builder> {
46-
public Builder(WhereModel whereModel) {
45+
public static class Builder extends AbstractBuilder<Builder> {
46+
public Builder(AbstractBooleanExpressionModel whereModel) {
4747
super(whereModel);
4848
}
4949

0 commit comments

Comments
 (0)