Skip to content

Commit 97e22d2

Browse files
committed
Move non-rendering where check to RenderingContext
1 parent 526b1b7 commit 97e22d2

File tree

4 files changed

+8
-6
lines changed

4 files changed

+8
-6
lines changed

src/main/java/org/mybatis/dynamic/sql/common/AbstractBooleanExpressionRenderer.java

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,11 +32,13 @@ public abstract class AbstractBooleanExpressionRenderer<M extends AbstractBoolea
3232
protected final M model;
3333
private final String prefix;
3434
private final CriterionRenderer criterionRenderer;
35+
protected final RenderingContext renderingContext;
3536

3637
protected AbstractBooleanExpressionRenderer(String prefix, AbstractBuilder<M, ?> builder) {
3738
model = Objects.requireNonNull(builder.model);
3839
this.prefix = Objects.requireNonNull(prefix);
39-
criterionRenderer = new CriterionRenderer(builder.renderingContext);
40+
renderingContext = Objects.requireNonNull(builder.renderingContext);
41+
criterionRenderer = new CriterionRenderer(renderingContext);
4042
}
4143

4244
public Optional<FragmentAndParameters> render() {

src/main/java/org/mybatis/dynamic/sql/render/RenderingContext.java

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -97,6 +97,10 @@ public String aliasedTableName(SqlTable table) {
9797
.orElseGet(table::tableNameAtRuntime);
9898
}
9999

100+
public boolean isNonRenderingClauseAllowed() {
101+
return statementConfiguration.isNonRenderingWhereClauseAllowed();
102+
}
103+
100104
/**
101105
* Create a new rendering context based on this, with the table alias calculator modified to include the
102106
* specified child table alias calculator. This is used by the query expression renderer when the alias calculator

src/main/java/org/mybatis/dynamic/sql/where/WhereModel.java

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -35,10 +35,6 @@ private WhereModel(Builder builder) {
3535
statementConfiguration = Objects.requireNonNull(builder.statementConfiguration);
3636
}
3737

38-
public boolean isNonRenderingClauseAllowed() {
39-
return statementConfiguration.isNonRenderingWhereClauseAllowed();
40-
}
41-
4238
/**
4339
* Renders a where clause without table aliases.
4440
*

src/main/java/org/mybatis/dynamic/sql/where/render/WhereRenderer.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@ private WhereRenderer(Builder builder) {
3131
public Optional<FragmentAndParameters> render() {
3232
Optional<FragmentAndParameters> whereClause = super.render();
3333

34-
if (whereClause.isPresent() || model.isNonRenderingClauseAllowed()) {
34+
if (whereClause.isPresent() || renderingContext.isNonRenderingClauseAllowed()) {
3535
return whereClause;
3636
} else {
3737
throw new NonRenderingWhereClauseException();

0 commit comments

Comments
 (0)