Finish replacing youtube-dl with yt-dlp #683
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @mxpv,
I finished replacing YouTube-dl with yt-dlp since YouTube-dl had a last release nearly 4 years ago. I updated the textual references but left the config and internal variables untouched to retain compatibility with configurations out there.
While doing that, I also moved yt-dlp from
/usr/bin
to/usr/local/bin
, which is better suited for external bins (one good use case is that you can easily override the whole/usr/local/bin
directory in Kubernetes/Docker and add your own stuff there without affecting system bins).And finally, I also changed the yt-dlp file permissions to 777 so the self-update feature works even for people who don't run the container as root.
I've been running the test build at home along with my other PR and it works well.
Log fragment: