Added support for parameter generator library #537
Conversation
rdelfin
force-pushed
the
parameter-library
branch
from
cb37edf to
43158e0
Compare
| url = "https://github.com/ros/urdfdom_headers/archive/refs/tags/1.0.6.tar.gz", | ||
| ) | ||
|
|
||
| maybe( |
There was a problem hiding this comment.
This is an autogenerated file, please move this to e.g. within https://github.com/mvukov/rules_ros2/blob/main/repositories/repositories.bzl#L237.
There was a problem hiding this comment.
Oh, I didn't realise this was autogenerated. I'll move it over
| requirement("Jinja2"), | ||
| requirement("typeguard"), |
There was a problem hiding this comment.
You'll need to update the req inputs and to regenerate the python lock file.
There was a problem hiding this comment.
Whoops... What I get for not checking from my test
ros2/parameters.bzl
Outdated
| load("@rules_cc//cc:defs.bzl", "cc_library") | ||
| load("@rules_python//python:defs.bzl", "py_library") | ||
|
|
||
| def parameter_library(name, parameter_file, cpp_header_name = None, python_file_name = None): |
There was a problem hiding this comment.
For me it's just fine to omit cpp_header_name and python_file_name and have them fixed.
Besides this, please split this macro to cc_ros2_parameter_library and py_ros2_parameter_library.
How is C++ namespace assigned?
There was a problem hiding this comment.
Oh, good question about the namespace! I'm not too sure, but let me see if that's configurable.
I put them together because of how I was using them, but splitting them into two makes a ton more sense
There was a problem hiding this comment.
Ok I've checked through and the namespace is based on the contents of the parameter file, so if you put the parameters in a my_parameters dictionary in the yaml file, it will put everything in the my_parameters namespace. I think you can nest to get more nested namespaces.
ros2/parameters.bzl
Outdated
| py = "{}.py".format(name) | ||
| else: | ||
| py = python_file_name | ||
| native.genrule( |
There was a problem hiding this comment.
I'd also create a python library that has this one as srcs.
|
I've added some fixes but they're incomplete, I'll re-request a review once I've gotten everything working |
rdelfin
force-pushed
the
parameter-library
branch
from
a74cbd2 to
92a2ffd
Compare
|
Took me a bit of work, but managed to get it working 😄 |
2 participants
A lot of ROS libraries use
generate_parameter_libraryto create parameter definitions with type information. This PR adds a bazel helper to use it and generate corresponding C++ and python libraries.