Allow customization of underlying rule in ros2_py_{binary,test}
#460
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
otiv-milan
reviewed
Apr 14, 2025
| @@ -46,19 +45,23 @@ def _ros2_py_exec(target, name, srcs, main, set_up_ament, **kwargs): | |||
| **launcher_target_kwargs | |||
| ) | |||
|
|
|||
| def ros2_py_binary(name, srcs, main, set_up_ament = False, **kwargs): | |||
| def ros2_py_binary(name, srcs, main, set_up_ament = False, target_rule = None, **kwargs): | |||
There was a problem hiding this comment.
TBH, I wouldn't change ros2_py_binary & ros2_py_test. I'd introduce ros2_py_exec where target_rule and is_test are exposed. That one would internally call _ros2_py_exec.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is what I had in mind. I can add an example where we use
rules_py, but wasn't sure whether pulling inrules_pyjust for this is justified.Fixes #458