Mention qualified property name in Get or Set errors #147
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ltering also drop the rspec-provided RakeTask class because it just cannot do what I need
impact: harmless
jreidinger
approved these changes
Apr 3, 2025
Before: The caller gets a D-Bus Error which includes interface and method name and they are org.freedesktop.DBus.Properties.Get which is not enough. After: Also include the property name and its interface.
mvidner
force-pushed
the
propget-error-mention-propname
branch
from
6f6b280 to
227ed1a
Compare
Since Ruby3.5 they are required, and they are available on the older versions too warning: logger was loaded from the standard library, but will no longer be part of the default gems starting from Ruby 3.5.0.
warning: loading in progress, circular require considered harmful - .../rubygems.rb
mvidner
force-pushed
the
propget-error-mention-propname
branch
from
227ed1a to
d56d5e6
Compare
Once in a while, keep up with RuboCop updates. 1.0 was released in 2020-10 1.30 in 2022-05 1.14 is the first one to support Ruby 3.1 but that would drop Ruby 2.4 1.30 is significant in reintroducing Ruby 2.4 2.4 is way old, but SUSE SLE 15 does keep using 2.5
earlier versions did nor require stringio
mvidner
force-pushed
the
propget-error-mention-propname
branch
2 times, most recently
from
c0f6036 to
35af371
Compare
in Gemfile, because gemspec cannot have a RUBY_VERSION condition
mvidner
force-pushed
the
propget-error-mention-propname
branch
from
8159984 to
160b673
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before:
The caller gets a D-Bus Error which includes interface and method name
and they are org.freedesktop.DBus.Properties.Get which is not enough.
After:
Also include the property name and its interface.