Skip to content

Changed OptPath to allow 'any' value #41

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 5, 2025
Merged

Changed OptPath to allow 'any' value #41

merged 3 commits into from
Apr 5, 2025

Conversation

djthorpe
Copy link
Member

@djthorpe djthorpe commented Apr 5, 2025

No description provided.

@djthorpe djthorpe requested a review from Copilot April 5, 2025 14:30
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.

Comments suppressed due to low confidence (1)

requestopts.go:120

  • [nitpick] Consider renaming the parameter 'value' to 'values' to better reflect that it represents a collection of items.
func join(value []any, sep string) string {

@djthorpe djthorpe requested a review from Copilot April 5, 2025 14:37
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 3 out of 4 changed files in this pull request and generated no comments.

Files not reviewed (1)
  • go.mod: Language not supported
Comments suppressed due to low confidence (2)

requestopts.go:47

  • [nitpick] Consider renaming the parameter from 'value' to 'values' to better indicate that multiple inputs are accepted and to maintain consistency with the join function parameter naming.
func OptPath(value ...any) RequestOpt {

requestopts.go:120

  • Ensure that the new join function is covered by unit tests to verify its behavior with various non-string input types.
func join(values []any, sep string) string {

@djthorpe djthorpe merged commit 3607a9a into main Apr 5, 2025
4 checks passed
@djthorpe djthorpe deleted the djt-0405-OptPath branch April 5, 2025 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant