-
-
Notifications
You must be signed in to change notification settings - Fork 470
Render stages for 3D primitives #3402
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
Nico8340
approved these changes
May 25, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good 🎉
Merged
Something went wrong @tederis If there is a 3D Material nearby, some dx images will be change to material's color. |
@Xenius97 Thanks for the report. I'll look into it. |
botder
pushed a commit
that referenced
this pull request
May 29, 2024
Fixes issue reported in comment: #3402 (comment)
MegadreamsBE
pushed a commit
to MegadreamsBE/mtasa-blue
that referenced
this pull request
Jun 6, 2024
MegadreamsBE
pushed a commit
to MegadreamsBE/mtasa-blue
that referenced
this pull request
Jun 6, 2024
Fixes issue reported in comment: multitheftauto#3402 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is aiming to fix a series of problems related to the purity of color of 3D lines and primitives(see #3399 and the discussion below #3321). It adds a new argument
"stage"
that can hold three values:"prefx"
,"postfx"
and"postgui"
.The syntax:
To make colors correct out of the box the stage
"postfx"
is used by default. For the sake of backward compatibility the"postGUI"
argument was preserved.The meaning of render stages:
postGUI = false
.postGUI = true
.The color that is used for these primitives: #4199d7.