Skip to content

Add UserID Sharing Capability with Consent Dialog (Related with Discord-RPC) #3267

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Dec 17, 2023

Conversation

znvjder
Copy link
Contributor

@znvjder znvjder commented Dec 10, 2023

This PR introduces the ability to share discord user IDs with servers if the user grants permission.
A special dialog has been added (look below), prompting the user (only once) to allow sharing their UserID, specifically when 'Allow connecting with Rich Presence' is enabled, and also when re-enabling this option.

Additionally, this PR adds the function:
string getDiscordRichPresenceUserID()

The function returns the user ID as a string if the user has granted permission; Otherwise, an empty string ("") is returned.

rpc

@1Lorenzo-1
Copy link

What's so private about initiating a dialogue to ask players if they want to share their Discord ID? It's just a Discord ID; if the player has allowed RPC, that's sufficient to obtain their Discord ID.

Similarly, if I set a custom code for the player in RPC and then retrieve it using an internal discord, bot that searches for members with a custom ID in their RPC.
I can get the dis-id too!

@znvjder
Copy link
Contributor Author

znvjder commented Dec 16, 2023

What's so private about initiating a dialogue to ask players if they want to share their Discord ID? It's just a Discord ID; if the player has allowed RPC, that's sufficient to obtain their Discord ID.

Similarly, if I set a custom code for the player in RPC and then retrieve it using an internal discord, bot that searches for members with a custom ID in their RPC. I can get the dis-id too!

You are partially correct, but we discussed about this some time ago on the developer channel. In general, Multi Theft Auto is open-source software that includes the option for synchronization with Rich Presence, and third parties can manage this (display various data).

Since the Discord Identifier (userid) is treated as personal data, obtaining and sharing it with third parties without explicit user consent may violate privacy policies and Discord's terms.

Therefore, we decided to be transparent with users and ask for their consent to share the identifier through a pop-up window. We should respect the privacy of users.

Copy link
Member

@Dutchman101 Dutchman101 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The design with privacy in mind is good (and as said, what we want). It's not a big change and has been code reviewed. Thanks

@Dutchman101 Dutchman101 merged commit acfbd40 into multitheftauto:master Dec 17, 2023
MTABot pushed a commit that referenced this pull request Dec 17, 2023
acfbd40 Add UserID Sharing Capability with Consent Dialog (Related with Discord-RPC) (#3267)
@StrixG StrixG added the enhancement New feature or request label Dec 21, 2023
@StrixG StrixG added this to the 1.6.1 milestone Dec 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants