Fix Unicode file path passed in CClientIMG #3171
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
botder
reviewed
Sep 3, 2023
Dutchman101
approved these changes
Sep 19, 2023
There was a problem hiding this comment.
We should just merge this as it has quite an impact for a bunch of foreign Windows users not to be able to load with new image functions. We're preparing the next main build, so i want to get this in.
It has been repeatedly code reviewed, and nothing more serious than something to do with style (which has also been sort of dismissed with feedback in the past 24hrs) has come out for objections, so i can merge it and any later improvements could be done in future PR's.
botder
added
bugfix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3166