Add arbitraries #24
Merged
Add arbitraries #24
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rklaehn
force-pushed
the
actyx/arbs
branch
3 times, most recently
from
fa62c2f to
bcac173
Compare
Merged
|
I've released rust-multihash 10.1 which includes the arbitraries. |
...and adapt to the new API
|
@vmx I am using the official multihash 0.10.1 now and am using the new API. So as far as I can see this is good to go. Not sure why the coverage test fails. Seems to be some CI config issue. |
Closed
vmx
approved these changes
Mar 9, 2020
vmx
reviewed
Mar 9, 2020
| let hash: Multihash = if !v0 { | ||
| Arbitrary::arbitrary(g) | ||
| } else { | ||
| if v0 { |
There was a problem hiding this comment.
(nitpick, no need to change it) Due to the API changes, this could be written as if version == Version::V0 {
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add arbitraries for Cid, Prefix and Codec