W-17864898: Mule framework DslSyntaxResolver resolves DslElementSynta… #1228
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…x inconsistent with schema in xsd file
|
--validate |
|
SonarQube Quality Gate
|
|
--validate |
elrodro83
requested changes
Jun 2, 2025
Comment on lines
-124
to
-131
| uncountable("equipment"); | ||
| uncountable("information"); | ||
| uncountable("rice"); | ||
| uncountable("money"); | ||
| uncountable("species"); | ||
| uncountable("series"); | ||
| uncountable("fish"); | ||
| uncountable("sheep"); |
There was a problem hiding this comment.
is it ok to remove these?
There was a problem hiding this comment.
They weren't working either way (because of the incorrect code in isUncountable), if we keep them we would actually be changing behavior of those cases
elrodro83
approved these changes
Jun 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…x inconsistent with schema in xsd file