Skip to content

[Experiment] Testing codemod behavior #7728

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
import React from 'react';

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @alexfauquette, do you have any examples of how your pickers change between versions? Maybe a diff? I can see if I can quickly mock something up for you 😊

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Most of the modifications have already been done:

The modification I proposed in codeshift comunity comes from migrate-to-components-componentsProps
which work well with self-closing elements

But I realized it was a problem when adding the transformation to our preset-safe

That's why I'm proposing to add a filtering condition on the parent

componentNames.includes(attributeParent.value.name.name)


const Button = (props) => {
return (
<button className="button" onClick={() => console.log('Hello, World!')}>
<div onClick={() => {}}> // This line is unchanged Submit</div>
</button>
);
};
Original file line number Diff line number Diff line change
@@ -0,0 +1,27 @@
import path from 'path';
import { expect } from 'chai';
import jscodeshift from 'jscodeshift';
import transform from '.';
import readFile from '../../../util/readFile';

function read(fileName) {
return readFile(path.join(__dirname, fileName));
}

describe.only('v6.0.0/pickers', () => {
describe('view-components-rename-value-prop', () => {
it('transforms props as needed', () => {
const actual = transform({ source: read('./actual.spec.js') }, { jscodeshift }, {});

const expected = read('./expected.spec.js');
expect(actual).to.equal(expected, 'The transformed version should be correct');
});

it('should be idempotent', () => {
const actual = transform({ source: read('./expected.spec.js') }, { jscodeshift }, {});

const expected = read('./expected.spec.js');
expect(actual).to.equal(expected, 'The transformed version should be correct');
});
});
});
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
import React from 'react';

const Button = (props) => {
return (
<button className="button">
<div onClick={() => {}}> // This line is unchanged Submit</div>
</button>
);
};
12 changes: 12 additions & 0 deletions packages/x-codemod/src/v6.0.0/pickers/experiment/index.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
export default function transformer(file, { jscodeshift: j }, options) {
const source = j(file.source);

source
.find(j.JSXElement)
.filter((path) => path.value.openingElement.name.name === 'button') // Find all button jsx elements
.find(j.JSXAttribute) // Find all attributes (props) on the button
.filter((path) => path.node.name.name === 'onClick') // Filter to only props called onClick
.remove(); // Remove everything that matched

return source.toSource();
}