-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
[Experiment] Testing codemod behavior #7728
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
9 changes: 9 additions & 0 deletions
9
packages/x-codemod/src/v6.0.0/pickers/experiment/actual.spec.js
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,9 @@ | ||
import React from 'react'; | ||
|
||
const Button = (props) => { | ||
return ( | ||
<button className="button" onClick={() => console.log('Hello, World!')}> | ||
<div onClick={() => {}}> // This line is unchanged Submit</div> | ||
</button> | ||
); | ||
}; |
27 changes: 27 additions & 0 deletions
27
packages/x-codemod/src/v6.0.0/pickers/experiment/adapter-change-import.test.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,27 @@ | ||
import path from 'path'; | ||
import { expect } from 'chai'; | ||
import jscodeshift from 'jscodeshift'; | ||
import transform from '.'; | ||
import readFile from '../../../util/readFile'; | ||
|
||
function read(fileName) { | ||
return readFile(path.join(__dirname, fileName)); | ||
} | ||
|
||
describe.only('v6.0.0/pickers', () => { | ||
describe('view-components-rename-value-prop', () => { | ||
it('transforms props as needed', () => { | ||
const actual = transform({ source: read('./actual.spec.js') }, { jscodeshift }, {}); | ||
|
||
const expected = read('./expected.spec.js'); | ||
expect(actual).to.equal(expected, 'The transformed version should be correct'); | ||
}); | ||
|
||
it('should be idempotent', () => { | ||
const actual = transform({ source: read('./expected.spec.js') }, { jscodeshift }, {}); | ||
|
||
const expected = read('./expected.spec.js'); | ||
expect(actual).to.equal(expected, 'The transformed version should be correct'); | ||
}); | ||
}); | ||
}); |
9 changes: 9 additions & 0 deletions
9
packages/x-codemod/src/v6.0.0/pickers/experiment/expected.spec.js
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,9 @@ | ||
import React from 'react'; | ||
|
||
const Button = (props) => { | ||
return ( | ||
<button className="button"> | ||
<div onClick={() => {}}> // This line is unchanged Submit</div> | ||
</button> | ||
); | ||
}; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,12 @@ | ||
export default function transformer(file, { jscodeshift: j }, options) { | ||
const source = j(file.source); | ||
|
||
source | ||
.find(j.JSXElement) | ||
.filter((path) => path.value.openingElement.name.name === 'button') // Find all button jsx elements | ||
.find(j.JSXAttribute) // Find all attributes (props) on the button | ||
.filter((path) => path.node.name.name === 'onClick') // Filter to only props called onClick | ||
.remove(); // Remove everything that matched | ||
|
||
return source.toSource(); | ||
} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @alexfauquette, do you have any examples of how your pickers change between versions? Maybe a diff? I can see if I can quickly mock something up for you 😊
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Most of the modifications have already been done:
The modification I proposed in codeshift comunity comes from
migrate-to-components-componentsProps
which work well with self-closing elements
But I realized it was a problem when adding the transformation to our
preset-safe
That's why I'm proposing to add a filtering condition on the parent