Weaken locale dependency #168
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @JackYoustra , Thanks to bring this issue, I bet the most straightforward and robust way would be: Expected behavior
What do you think? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you run code2prompt on a system with an unset locale (such as ssh'ed wsl2), it can crash when using format token. I weaken this and make the format token flag only take effect if systemlocale is valid.
There are other approaches possible too: we could change the default_value to be raw if systemlocale is invalid, for example. I'm not sure what the best approach is for a tool like this. If the maintainers think a different direction is better, feel free to comment and I'll revise.