-
Notifications
You must be signed in to change notification settings - Fork 0
Csspurge #4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR refactors many pages and components by updating import paths to use the configured alias (using "@/…"), cleaning up unused CSS files, and updating several UI elements for improved consistency and design. Key changes include:
- Refactored import statements across all service pages and components to use path aliasing.
- Updates to inline styling and icon classes (e.g. from "icon-arrow-right-double" to "fas fa-chevron-right") and UI component modifications (e.g. Quality and ServiceSlider components).
- Minor performance and layout adjustments in JavaScript slider configuration and map popup contents.
Reviewed Changes
Copilot reviewed 49 out of 56 changed files in this pull request and generated no comments.
| File Category | Description |
|---|---|
| Astro Pages & Components | Consistent use of aliasing for imports; updated inline styles and icon classes |
| UI Components (Quality, ServiceSlider, Footer, CSSbase) | Enhanced component structure, styling consistency, and design improvements |
| Public Assets (JS files: map.js, main.js) | Adjustments in slider settings and map popup formatting to align with design guidelines |
Comments suppressed due to low confidence (5)
src/components/ServiceSlider.astro:71
- [nitpick] The service title change to 'Driveway Paving' deviates from the previous 'Asphalt Paving' label; please confirm that this naming update is intentional and consistent with the service offerings across the site.
</h3>
public/assets/js/map.js:92
- The updated popupContent inline style reduces padding and font size; please confirm that these changes align with the overall design guidelines for consistent UI across the site.
<div style="text-align: center; padding: 1px;">
src/components/CSSbase.astro:3
- Ensure that the reordering and consolidation of CSS imports maintains the intended cascade and specificity, avoiding unintended style overrides from external or local styles.
import "@/assets/css/main.css";
src/pages/services/sealer.astro:301
- The update to use Font Awesome's 'fas fa-chevron-right' icon improves visual consistency; please ensure this change is applied uniformly across all similar components.
>
public/assets/js/main.js:725
- [nitpick] The slider configuration change reducing slidesPerView from 3 to 2 at the 1200px breakpoint may impact layout and user experience; please verify that this change is intentional and consistent with the design requirements.
slidesPerView: 2,
This pull request includes changes to improve configuration and dependencies while removing unused CSS files. The most important changes involve setting up path aliasing in the
astro.config.mjsfile, adding a new dependency topackage.json, and cleaning up unused stylesheets.Configuration Updates:
astro.config.mjs: Added aresolve.aliasconfiguration to define@as a path alias pointing to thesrcdirectory. This simplifies imports throughout the project.Dependency Updates:
package.json: Added@fortawesome/fontawesome-freeas a new dependency to support Font Awesome icons.Code Cleanup:
public/assets/css/icomoon.css: Removed the file containing unused icon font definitions.public/assets/css/magnific-popup.css: Removed the file containing unused styles for a popup library.public/assets/css/map.css: Removed the file containing unused styles for map-related components.public/assets/css/slick.css: Removed the file containing unused styles for a slider library.Minor Adjustments:
.vscode/settings.json: Updated the width (w) of thepinyfakepage.htmlview from788to660.