Integración de mejoras de Codex: validación automática y generación de archivos #1
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR integrates Codex-generated enhancements across the site, focusing on lint fixes, style/format improvements for Astro components, dynamic page regeneration from CSV, and removal of unused code.
- Adds a Vitest configuration and a basic Footer test.
- Updates many service pages to import images as modules and use
<Image>components. - Standardizes canonical URLs (adds trailing slashes) and converts inline background divs to use dynamic
styleattributes.
Reviewed Changes
Copilot reviewed 64 out of 256 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| vitest.config.ts | Introduces Vitest setup for jsdom environment and test patterns. |
| tests/Footer.test.ts | Adds a smoke test to verify the footer renders the phone number. |
| src/pages/services/**/*.astro | Converts asset paths to imported variables, updates URLs, and banner thumbnails. |
Comments suppressed due to low confidence (1)
src/pages/services/sealer/sealcoating.astro:9
- New service pages like Sealcoating have been added but currently lack any associated tests. Consider adding snapshot or integration tests to verify that key content and image imports render correctly.
import MainServices from "../../../components/MainServices.astro";
| <a | ||
| class="popup-image" | ||
| href="/assets/imgs/service/sealer/sealcoating-1.webp" | ||
| > |
There was a problem hiding this comment.
Image components used in the project slider section lack explicit width and height attributes, which may cause layout shifts and affect performance. Consider adding width and height props to these components to reserve space and improve load stability.
| data-background="/assets/imgs/service/sealer.webp" | ||
| > | ||
| </div> | ||
| <div class="banner-thumb" style={`background-image: url('${sealerServiceBg.src}');`}></div> |
There was a problem hiding this comment.
[nitpick] This banner-thumb pattern is repeated across many service pages; consider extracting it into a shared component (e.g., ) to reduce duplication and simplify future updates.
buildEste pull request incluye los siguientes cambios generados por Codex:
✔️ Revisión hecha con Copilot activado