Skip to content

Add support for posting comments #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Conversation

reavessm
Copy link
Contributor

Probably should merge this after #5

Signed-off-by: Stephen Reaves <reaves735@gmail.com>
Signed-off-by: Stephen Reaves <reaves735@gmail.com>
Signed-off-by: Stephen Reaves <reaves735@gmail.com>
Signed-off-by: Stephen Reaves <reaves735@gmail.com>
@msuchane msuchane self-assigned this May 7, 2025
@msuchane
Copy link
Owner

msuchane commented May 7, 2025

Thanks for the PR, @reavessm. I've finally reviewed it and made some changes:

  • This crate already uses log for logging so I replaced tracing with log. If you'd like to reintroduce tracing, though, I don't mind -- I just think it should be consistent across the whole crate. We could have both side by side.
  • I've also changed the logging level from info to debug because I believe that's more appropriate for this kind of information.
  • I saw a TODO item about commenting as myself or as another user. I've added an implementation for specifying another user but I can't test it now. Could you please try it out and let me know if it works for you?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants