Store symbol tables separately from fxprof_processed_profile::LibraryInfo #551
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Info. We already have a separate Profile::set_lib_symbol_table method so just use that always. Most consumers just specify None, and now they don't have to do that anymore. But the main motivation for this change was performance: We were hashing the symbol table during calls to handle_for_lib. This fixes that.
mstange
force-pushed
the
push-kzmtupwovrzu
branch
from
020d72d to
296b78a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We already have a separate Profile::set_lib_symbol_table method so just use that always. Most consumers just specify None, and now they don't have to do that anymore.
But the main motivation for this change was performance: We were hashing the symbol table during calls to handle_for_lib. This fixes that.