Skip to content

Some fxprof-processed-profile API changes #524

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Mar 8, 2025
Merged

Some fxprof-processed-profile API changes #524

merged 4 commits into from
Mar 8, 2025

Conversation

mstange
Copy link
Owner

@mstange mstange commented Mar 8, 2025 •
edited
Loading

  • Rename intern_string to handle_for_string. Do the same for intern_frame, intern_stack and so on.
  • Change add_category and add_subcategory to handle_for_category and handle_for_subcategory.
  • For markers, make the category part of the schema. Add a static Category type to make this possible for StaticSchemaMarker.

@mstange mstange enabled auto-merge March 8, 2025 02:27
@mstange mstange force-pushed the new-category-api branch 5 times, most recently from b657e73 to f658568 Compare March 8, 2025 03:04
@mstange mstange force-pushed the new-category-api branch from f658568 to 1f9fdd3 Compare March 8, 2025 03:10
@mstange mstange merged commit 884da76 into main Mar 8, 2025
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@mstange