Skip to content

Reduce JSON size some more by removing the implementation column and using 0 instead of null in the innerWindowID column #522

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 7, 2025

Conversation

mstange
Copy link
Owner

@mstange mstange commented Mar 7, 2025

No description provided.

mstange added 3 commits March 7, 2025 16:49
The profiler front-end treats null and 0 the same in this column.
Really we don't want to have this column at all, see firefox-devtools/profiler#5006 .

But 0 at least takes up fewer bytes in the JSON file than null.
@mstange mstange enabled auto-merge March 7, 2025 21:50
@mstange mstange merged commit 1ade1ea into main Mar 7, 2025
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant