Reduce JSON size, emit version 53 #506
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… the category + subcategory columns.
This is supported starting with version 50, and we use version 53 now. Deltas can be more compact to store in the stringified JSON form, because they'll often have fewer digits before the decimal point.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I recently landed a change in the front-end to reduce some redundancy in the profile JSON; the stackTable now doesn't need to duplicate the category + subcategory information anymore. This is supported starting with version 53 of the processed profile format.
Furthermore, we can encode sample timestamps as deltas to save space, this is supported starting with version 50 of the processed profile format.
There are more changes in the pipeline to reduce the JSON size, but as of today only 53 is supported in the deployed version at profiler.firefox.com.