Add ignore exit code flag #490
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mstange
requested changes
Feb 6, 2025
samply/src/windows/profiler.rs
Outdated
| @@ -100,6 +100,10 @@ pub fn start_recording( | |||
|
|
|||
| pids.push(child.id()); | |||
|
|
|||
| if process_launch_props.ignore_exit_code { | |||
There was a problem hiding this comment.
I don't think this is right - you need to wait for the child process to finish before you launch the next iteration. Can you combine this check with the existing !exit_status.success() check?
There was a problem hiding this comment.
You are correct, this condition should go after the wait call. Have updated 👍
|
Have put in the fix for |
|
Merged, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
ignore_exit_codeflag so that iteration count can continue even if the process returned a non-zero exit code (which is common on linters / verifiers etc)