Fix glitches caused by Verible LS #503
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since HDL-support has implemented the diagnostics and formatter, the verible LS should not directly provide these features.
|
LGTM. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #449
Fix #487
Modified the option of
veribleVerilogLsto include amessageStrategythat handles and modifies the language server capabilities by removing unnecessary diagnostic and formatting providers.#449 and #487 occurred as the same features are provided twice by HDL support and verible LS. All things work fine now.
Please notice that this patch does not disable any features of Verible LS. Instead, they are just suppressed and letting VSCode not able to realize that the language server provide these features. VSCode therefore has to turn to our extension for formatter and diagnostics.