Skip to content

WebGLRenderer: Rename reverseDepthBuffer-> reversedDepthBuffer #31407

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 14, 2025

Conversation

sunag
Copy link
Collaborator

@sunag sunag commented Jul 13, 2025

Related issue: #31391 (comment)

Description

Fix consistency renaming reverseDepthBuffer-> reversedDepthBuffer.

@sunag sunag added this to the r179 milestone Jul 13, 2025
Copy link

📦 Bundle size

Full ESM build, minified and gzipped.

Before After Diff
WebGL 338.27
78.93
338.28
78.93
+10 B
-2 B
WebGPU 558.52
154.58
558.52
154.58
+0 B
+0 B
WebGPU Nodes 557.45
154.37
557.45
154.37
+0 B
+0 B

🌳 Bundle size after tree-shaking

Minimal build including a renderer, camera, empty scene, and dependencies.

Before After Diff
WebGL 469.62
113.66
469.63
113.66
+10 B
-2 B
WebGPU 634.18
171.62
634.18
171.62
+0 B
+0 B
WebGPU Nodes 589.31
160.95
589.31
160.95
+0 B
+0 B

@@ -232,7 +232,7 @@
logarithmicComposer.addPass( new OutputPass() );

const reverseContainer = document.getElementById( 'container_reverse' );
reverseRenderer = new THREE.WebGLRenderer( { reverseDepthBuffer: true } );
reverseRenderer = new THREE.WebGLRenderer( { reversedDepthBuffer: true } );
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given that the reverse depth buffer was relatively new and somewhat experimental, I think we can quit the deprecation warning. A note in the migration guide about the renaming should be sufficient.

@sunag sunag marked this pull request as ready for review July 14, 2025 23:58
@sunag sunag merged commit c543bf7 into mrdoob:dev Jul 14, 2025
9 checks passed
@sunag sunag deleted the dev-rename branch July 14, 2025 23:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants