build: MSVC fix for unspecified std::chrono::duration type #731
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Another patch to get the MSVC build going.
The
chrono_literals
operator""s
actually has an unspecified return type (https://eel.is/c++draft/time.duration.literals).So library implementations can end up with either
double
orlong double
as the duration rep. For instance,Clang's implementation:
MSVC's implementation:
I changed the assertion to grab the rep from the result of calling the operator. Looks a bit tautological, but it works.