fix: enable runtime usage of inverse function by using compile-time unit extraction #726
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mpusz
reviewed
Sep 29, 2025
| #if MP_UNITS_API_NATURAL_UNITS | ||
| if constexpr (!MP_UNITS_ASSOCIATED_UNIT<MP_UNITS_REMOVE_CONST(decltype(To))>) | ||
| return (representation_values<Rep>::one() * one).force_in(To * q.unit) / q; | ||
| return (representation_values<Rep>::one() * one).force_in(To * get_unit(R)) / q; |
There was a problem hiding this comment.
I don't think those change anything.
I just checked your unit tests with the mainline implementation of math.h on clang-16, clang-21, gcc-12, and gcc-15. All of the inverse unit tests provided below compile without issues, requiring no changes to math.h.
Could you please recheck?
There was a problem hiding this comment.
I checked again with Clang 16, 17, and 21. These new tests compile with Clang 16 but not 17 or 21 (I think because of this macro https://github.com/mpusz/mp-units/blob/master/src/core/include/mp-units/bits/hacks.h#L125-L129).
Attached are build errors from Clang 21 with these tests.
inverse-error.txt
I originally noticed this error in CI for use of inverse in my Audio Examples PR (#644)
rothmichaels
force-pushed
the
fix/optimal-inverse-runtime
branch
from
e6b40d6 to
b6f46a7
Compare
…nit extraction Replace runtime unit access (q.unit) with compile-time type extraction (get_unit(R)) in the inverse function implementation. This prevents the function from becoming an immediate function when consteval unit operators are used, allowing inverse to work with runtime variables. Key changes: - math.h: Use get_unit(R) instead of q.unit in both code paths - test: Add comprehensive runtime inverse tests This surgical fix preserves maximum compile-time optimization while enabling DSP applications that need runtime inverse calculations. Fixes compilation error with Clang: "call to immediate function 'inverse' is not a constant expression" 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
rothmichaels
force-pushed
the
fix/optimal-inverse-runtime
branch
from
b6f46a7 to
45754e7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace runtime unit access (q.unit) with compile-time type extraction (get_unit(R)) in the inverse function implementation. This prevents the function from becoming an immediate function when consteval unit operators are used, allowing inverse to work with runtime variables.
Key changes:
This surgical fix preserves maximum compile-time optimization while enabling DSP applications that need runtime inverse calculations.
Fixes compilation error with Clang:
"call to immediate function 'inverse' is not a constant expression"
🤖 Generated with Claude Code