build: explicit_this enabled for AppleClang 17 and MSVC 19.32
#723
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mpusz
requested changes
Sep 24, 2025
|
Please also run |
|
Don't worry about Freestanding failures. They are caused by a CMake bug that will hopefully be resolved soon. Dependency Review is also experimental and we are working on improving it. |
Both compilers do not implement the feature test macro, but they do implement `explicit_this`, as mentioned in their corresponding release notes: - https://developer.apple.com/documentation/xcode-release-notes/xcode-16_3-release-notes - https://learn.microsoft.com/en-us/visualstudio/releases/2022/release-notes-v17.2 Resolves mpusz#722.
|
Thanks for the review! Resolved all issues.
I've also edited the part of the docs that says explicit |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Both compilers do not implement the feature test macro, but they do implement
explicit_this, as mentioned in their corresponding release notes:Resolves #722.