Fix Xcode long build times and/or crashes #697
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit c2672c0.
This reverts commit 7d340d9. This fix was causing the following error: ``` fatal error: error in backend: SmallVector unable to grow. ```
For some reason this new implementation of `RepresentationOf` was causing long build times again in the Kalman fiter examples. I'm not sure why this is and if we should keep the old implemention only for Xcode 15 or if we should revert this implementation change in general.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first attempted fix for long build times with Xcode 15 was causing a compiler crash.
The refactor to remove
concept Representationseemed to cause an unexplained long build time for Xcode 15 building Kalman filter examples. Reverting the changes toconcept RepresentationOfin Xcode 15 seems to resolve the long build times. I'm not sure if we should revert this change just for Xcode 15 or in general.